Allow parsing list blobs response without ServerEncrypted tag #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is how Azurite responds when a blob is created by multi-block algorithm
demoray
approved these changes
Feb 21, 2023
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow parsing list blobs response without ServerEncrypted tag, which is how Azurite responds when a blob is created by multi-block algorithm.
By default, it will assume this tag is false.
I wasn't able to test this using the e2e provided with my Azurite credentials. But I was able to test this issue independently, and I added a few tests to cover this situation. The payload in
deserde_azurite_without_server_encryptedis a true payload that happened to me while listing blobs.I'm not sure if it makes a difference, but this is how my container is setup:
azurite --blobHost 0.0.0.0 --queueHost 0.0.0.0 --tableHost 0.0.0.0 --loose