Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to using quick-xml instead of serde-xml-rs #1227

Merged
merged 4 commits into from
Feb 23, 2023
Merged

move to using quick-xml instead of serde-xml-rs #1227

merged 4 commits into from
Feb 23, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Feb 22, 2023

Fixes #1226

johnbatty
johnbatty reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@johnbatty johnbatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good - particularly the way you have removed the direct xml crate dependencies from the storage crates, consolidating the function into azure_core.

sdk/storage_blobs/src/blob/block_with_size_list.rs Outdated Show resolved Hide resolved
sdk/storage_blobs/src/blob/block_with_size_list.rs Outdated Show resolved Hide resolved
sdk/core/Cargo.toml Outdated Show resolved Hide resolved
johnbatty
johnbatty approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@johnbatty johnbatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@demoray demoray merged commit 445014f into Azure:main Feb 23, 2023
@demoray demoray deleted the move-to-quick-xml branch February 23, 2023 19:48
@JelteF
Copy link

JelteF commented Mar 2, 2023

Would it be possible to create a new release with this change? I'd quite like to not have the unmaintained warning in the cargo deny check output.

@demoray
Copy link
Contributor Author

demoray commented Mar 2, 2023

I will investigate doing a new release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbatty johnbatty johnbatty approved these changes

@cataggar cataggar cataggar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK uses unmaintained crate xml-rs
4 participants
@demoray @JelteF @johnbatty @cataggar