Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-generate services #1285

Merged
merged 1 commit into from
May 22, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented May 22, 2023

@demoray demoray requested a review from johnbatty May 22, 2023 16:39
@demoray demoray mentioned this pull request May 22, 2023
@@ -6,12 +6,12 @@ https://github.com/Azure/azure-rest-api-specs/blob/main/specification/azurearcda

To get started with these generated service crates, see the [examples](https://github.com/Azure/azure-sdk-for-rust/blob/main/services/README.md#examples).

The default tag is `package-preview-2023-03`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanning through a selection of the changes, I was a little surprised to see some of the latest versions switch to an older version. However, it seems that this is just due (in this case at least) to the newer API being removed, e.g. for ArcData:

So this appears to be fine.

- `package-dotnet-sdk` has 197 operations from 20 API versions: `2015-06-01-preview`, `2017-08-01`, `2017-08-01-preview`, `2019-01-01`, `2019-01-01-preview`, `2019-08-01`, `2020-01-01`, `2020-01-01-preview`, `2021-01-15-preview`, `2021-05-01-preview`, `2021-06-01`, `2021-07-01-preview`, `2021-10-01-preview`, `2022-01-01`, `2022-01-01-preview`, `2022-03-01`, `2022-05-01`, `2022-07-01-preview`, `2022-08-01-preview`, `2023-02-01-preview`. Use crate feature `package-dotnet-sdk` to enable. The operations will be in the `package_dotnet_sdk` module.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that there are some significant changes to the security package names. I'm presuming that this is fine - it is autogenerated and builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little odd, but something we can address in later updates.

Copy link
Contributor

@johnbatty johnbatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of observations, but think it looks good.

@demoray demoray merged commit 0994d91 into Azure:main May 22, 2023
8 checks passed
@demoray demoray deleted the dev/bcaswell/update-services-from-spec branch May 22, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants