Public response when no response type defined #1349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348. We want access to the internal response in all cases. It was skipped when a response type wasn't defined in the schema.
Now the generated code includes the following
impl Response
when there are no headers:and if there are headers, they are included as well:
I updated the changelog, even though I'm not generating a new version. I was able to generate updated SDKs locally after adding
package-2023-09-01-preview
to /svc/devcenter/autorust.toml and removing thequota
spec.Let me know if there's something I can do to help with publishing or if I missed anything. I plan to generate the compute for myself and use a patched version.