allow creating LeaseId from Uuid #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation of for LeaseId states it must be in the format of a UUID. > x-ms-proposed-lease-id: <ID> Optional for acquire, and required for change. Proposed lease ID, in a GUID string format. Blob Storage returns 400 (Invalid request) if the proposed lease ID isn't in the correct format. See Guid Constructor (String) for a list of valid formats. Right now, users that have a lease id as a Uuid must convert it into a string, then from_str the result. This allows directly converting to a LeaseId from a Uuid. ref: https://learn.microsoft.com/en-us/rest/api/storageservices/lease-container?tabs=azure-ad
johnbatty
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of for LeaseId states it must be in the format of a UUID.
Right now, users that have a lease id as a Uuid must convert it into a string, then from_str the result.
This allows directly converting to a LeaseId from a Uuid.
ref: https://learn.microsoft.com/en-us/rest/api/storageservices/lease-container?tabs=azure-ad