Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide SeekableStream impl for tokio::fs::File #1364

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Sep 7, 2023

Addresses #1219

This builds upon #1359, #1358, and #1357 and those are required for this PR to build correctly.

sdk/core/src/tokio/fs.rs Outdated Show resolved Hide resolved
sdk/core/src/tokio/fs.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but overall I think this looks good!

sdk/core/src/tokio/fs.rs Outdated Show resolved Hide resolved
sdk/core/src/tokio/fs.rs Show resolved Hide resolved
@demoray demoray marked this pull request as ready for review September 11, 2023 14:28
@demoray demoray merged commit 69709be into Azure:main Sep 12, 2023
16 checks passed
@demoray demoray deleted the streamable-files branch September 12, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants