wasm32 target support (v2) #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoray
reviewed
Sep 11, 2023
demoray
reviewed
Sep 11, 2023
demoray
reviewed
Sep 11, 2023
demoray
approved these changes
Sep 11, 2023
cataggar
reviewed
Sep 12, 2023
| time = { version = "0.3.10", features = ["serde-well-known", "macros", "local-offset"] } | ||
|
|
||
| # When target is `wasm32`, include `getrandom` and enable `wasm-bindgen` feature in `time`. | ||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| time = { version = "0.3.10", features = ["serde-well-known", "macros", "local-offset", "wasm-bindgen"] } | ||
| time = { version = "0.3.10", features = ["wasm-bindgen"] } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces my earlier draft wasm PR: #1128
The main changes are as follows.
azure_core
reqwestand creation of a reqwest http client in thehttp_clientmodule when the target is wasm32wasm32target omit the Send trait when using async_trait by specifyingasync_trait(?Send)reqwestsupport (0.11.14) forwasmimplementation ofResponse::bytes_stream()wasm32target remove support forBody::SeekableStreamreqwest::Body::wrap_stream()is not implemented for WASMwasm32limitation for nowwasm32target remove Send + Sync from thePinnedStreamdefinitionwasm-bindgenthat enablestime/wasm-bindgento allow the UTC time to be queried via the browser APIautorust
Update
autorustto useLocalBoxFutureforwasm32target rather thanBoxFutureAutogenerated services
Regenerate with modified
autorust