Fix paging via params for generated crates #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 15, 2023 10:27
This addresses a handful of XML parsing issues in generated crates. 1. Deserializing enum variants with the value being a string content (such as `<field>Value</field>`) needs a serde helper. 2. Deserializing attribute values (such as `<a b="foo"/>`) needs to the attribute name to be prefixed with `@` to indicate it's an attribute 3. Continuation tokens that are strings need to be considered the same as not having a continuation token Additionally, this PR includes the following: 1. Regenerating the `azure_svc_blobstorage` crate for review 2. A unit test for `azure_svc_blobstorage` that validates the XML parsing works as intended 3. Updates to the `azure_svc_blobstorage` example such that it no longer silently swallows parsing issues Once this PR is reviewed, I will submit a follow-on PR that includes regenerating the rest of the crates. Ref: <https://docs.rs/quick-xml/latest/quick_xml/serde_helpers/text_content/index.html> Ref: <https://docs.rs/quick-xml/latest/quick_xml/de/index.html#mapping-xml-to-rust-types>
demoray
pushed a commit
to demoray/azure-sdk-for-rust
that referenced
this pull request
Sep 15, 2023
This PR shows the results of regenerating the crates with Azure#1381 and Azure#1383 applied.
This was referenced Sep 15, 2023
cataggar
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses generated crates that use next-link-name style paging, but the paging name refers to a parameter rather than a URL replacement. This fixes paging for the
azure-svc-storageblobs.Note: This PR is built on top of #1381. Until #1381 is merged, to review the unique changes for this PR, check out the last commit to this branch.