remove local-offset feature from time in azure_core #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoray
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
I support the desire to rely on az-cli handling this for us in the future, as well as moving this to azure-identity, as it's the only place we use it.
My suggestion to make this pub(crate) is such that we don't expose it for consumption by 3rd parties since it's an internal implementation detail we hope to remove soon.
Otherwise, LGTM.
Co-authored-by: Brian Caswell <bcaswell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
assume_localfunction. Once #1371 is addressed, it should be possible to remove the function andlocal-offsetfrom azure_identity as well, but that will be in a later PR.