add models to autorust's reserved words
#1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we use `models` heavily throughout to describe where the generated structs are stored, services that use `models` as a identifier name will cause issues. By adding `models` to the pre-existing `is_keyword` and using a something that doesn't check `is_keyword` for when we _actually_ want `models`, we can generate code for services that use the keyword `models`. Fixes Azure#1382
demoray
pushed a commit
to demoray/azure-sdk-for-rust
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use
modelsheavily throughout to describe where the generated structs are stored, services that usemodelsas a identifier name will cause issues.By adding
modelsto the pre-existingis_keywordand using a something that doesn't checkis_keywordfor when we actually wantmodels, we can generate code for services that use the keywordmodels.Fixes #1382 (once the services are re-generated after this PR is merged).