Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #[serde(flatten)] annotation and add ResourceType value #1436

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

CHarrod283
Copy link
Contributor

Bug 1: When storage_blobs::blob::BlobProperties deserializes with an unknown field it errors.

Reason: Deserialization is iffy in regard to XMl. This is due to ambiguous typing. Deserialization will interpret the inner field as a map as opposed to a string, thus resulting in a failed conversion with the #[serde(flatten)] annotation and as such, an error.

Fix: Change the map to use serde_json::Value

Bug 2: List blobs response occasionally can contain a ResourceType field. This isn't deserialized to a public field.

Fix: Add the field

…n unknown field it errors.

Reason: Deserialization of xml is iffy in regard to XMl. This is due to ambiguous typing. Deserialization will interpret the inner field as a map as opposed to a string, thus resulting in a failed conversion with the #[serde(flatten)] annotation and as such, an error.

Fix: Change the map to use serde_json::Value

Bug 2: List blobs response occasionally can contain a `ResourceType` field. This isn't deserialized to a public field.

Fix: Add the field
@CHarrod283
Copy link
Contributor Author

@microsoft-github-policy-service agree

@CHarrod283 CHarrod283 changed the title Bug 1: When storage_blobs::blob::BlobProperties deserializes with a… Fix #[serde(flatten)] annotation and add ResourceType value Oct 6, 2023
@demoray demoray merged commit f290339 into Azure:main Oct 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants