Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate services #1442

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Oct 23, 2023

@demoray demoray requested a review from cataggar October 23, 2023 20:17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only manual configuration was to ignore a preview tag for defining an object twice.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a sustainable model. We don't build SDKs for all services. Each SDK that we do generate is done so when the service is updated. If we keep updating all sources like this, there will always be differences from generators thus clients won't be stable. Perhaps it's moot since we're not a stable version (and won't be until official, at the very least), but perhaps we need to rethink when/how we regenerate.

@demoray
Copy link
Contributor Author

demoray commented Oct 23, 2023

I don't think this is a sustainable model. We don't build SDKs for all services. Each SDK that we do generate is done so when the service is updated. If we keep updating all sources like this, there will always be differences from generators thus clients won't be stable. Perhaps it's moot since we're not a stable version (and won't be until official, at the very least), but perhaps we need to rethink when/how we regenerate.

I agree this isn't sustainable as is. The Go SDK used this model for some time and has since moved to the "sdk-release-request" model, which aligns to the idea you commented on, generating based on service update.

IMO, this is one of the multitude of things we will need to adjust to align to the SDK release process as part of the "becoming official" process.

@demoray demoray merged commit b9d1639 into Azure:main Oct 30, 2023
19 checks passed
@demoray demoray deleted the regenerate-services-2023-10-23 branch October 30, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants