add range header in put_block_url function #1446
Conversation
|
@microsoft-github-policy-service agree |
| @@ -23,6 +24,11 @@ impl PutBlockUrlBuilder { | |||
| let mut headers = Headers::new(); | |||
| headers.insert(COPY_SOURCE, self.url.to_string()); | |||
| headers.add(self.lease_id); | |||
| if let Some(mut range) = self.range { | |||
| // to accomodate with the standard HTTP range header format: | |||
There was a problem hiding this comment.
The current range implementation used by the SDK is intended to be an inclusive end.
For reference:
azure-sdk-for-rust/sdk/core/src/request_options/range.rs
Lines 82 to 83 in 1b676a1
We need to document this behavior and be more intentionally specific about it.
There was a problem hiding this comment.
Not sure whether the current comitted version is correct...It's kind of weird for the user to give in a range of [0,1000] to obtain the range header bytes=0-999.
There was a problem hiding this comment.
Understood. The current handling of Range is suboptimal.
Our range implementation maps more closely to RangeInclusive in practice. As identified in #1438, we need to clean this up in a handful of different places.
As described in document, the
put_block_urlfunction has ax-ms-source-rangeheader request option.