Support user delegated sas urls #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of note, this implementation does not include support for the optional fields at this time. That will be handled in a follow-up PR, as we have a number of other optional signing fields that are not supported already, and this could use some refactoring to support them appropriately. |
cataggar
approved these changes
Dec 1, 2023
| @@ -190,7 +191,7 @@ impl AccountSharedAccessSignature { | |||
| self.version, | |||
| ); | |||
|
|
|||
| hmac_sha256(&string_to_sign, &self.key).unwrap() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for user-delegated-key SAS URLs.
This includes changing the azure storage API version to 2022-11-02, which aligns with the Python SDK's current usage for their supported implementation of user-delegated-keys.
Probably of most use is how this new API is used, which is included in the example sdk/storage_blobs/examples/user_delegation_keys.rs.
This PR is broken up into 3 commits:
An issue that this PR highlights is that the mock transaction recording isn't order stable, which results in larger changes than we would otherwise expect.