Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose default tag as feature #1492

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Dec 5, 2023

Right now, if you want to specify the http client implementation, you also must specify the package tag which can change regularly during updates.

This moves to including a feature named default_tag which refers to the specific tag name, as well as renames no-default-tag to without_tag_import to do what was previously referred as no-default-tag.

This allows users to have a consistent Cargo.toml entry for the latest tag and a specified http client such as the following:

azure_svc_batch = {version="0.17", default-features=false, features=["enable_reqwest", "default_tag"]}

This PR is broken up into two commits. The first is the change to the generator. The second is the changes after regenerating the crates.

Brian Caswell added 2 commits December 5, 2023 15:14
Right now, if you want to specify the http client implementation, you
_also_ must specify the package tag which can change regularly during
updates.

This moves to including a feature named `default_tag` which refers to
the specific tag name, as well as renames `no-default-tag` to
`without_tag_import` to do what was previously referred as
`no-default-tag`.

This allows users to have a consistent Cargo.toml entry for the latest
tag and a specified http client such as the following:

`azure_svc_batch = {version="0.17", default-features=false, features=["enable_reqwest", "default_tag"]}`
@demoray demoray requested a review from cataggar December 5, 2023 20:20
@demoray
Copy link
Contributor Author

demoray commented Dec 5, 2023

Note, this is important as I am looking to address #1487 by making use of models from the generated crate, where we want to specify the HTTP client but not have to keep the default tag up-to-date.

@demoray demoray merged commit 5ceb125 into Azure:main Dec 6, 2023
19 checks passed
@demoray demoray deleted the expose-default-tag-as-feature branch December 6, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants