Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move away from directory listings for finding generated crates #1509

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Dec 8, 2023

As identified in #1479, we do not currently handle deleted/renamed specifications well.

This update addresses this via the following:

  • Moves to using parsing cargo_toml to parse services/Cargo.toml to know what crates already exist
  • Replaces all uses of list_crate_names with using the results of gen_crates

As a byproduct, this identifies that the previously existing spec that would result in azure_svc_codesigning was removed.

ref: Azure/azure-rest-api-specs#26635

As identified in Azure#1479, we do not currently handle deleted/renamed specifications well.

This update addresses this via the following:
* Moves to using parsing `cargo_toml` to parse services/Cargo.toml to know what crates already exist
* Replaces all uses of `list_crate_names` with using the results of `gen_crates`

As a byproduct, this identifies that the previously existing spec that would result in `azure_svc_codesigning` was removed.

ref: Azure/azure-rest-api-specs#26635
@demoray demoray requested a review from cataggar December 8, 2023 19:22
@demoray demoray merged commit 7273f11 into Azure:main Dec 8, 2023
19 checks passed
@demoray demoray deleted the dont-use-directory-listings-for-identifying-crates branch December 8, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants