Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include path and x_ms_path endpoints in genearted crates #718

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Apr 7, 2022

This addresses an issue where some specs split endpoints between path
and x-ms-path. This exposes a significant number of operations across
the generated crates that were not previously included.

NOTE: this was generated using version of the REST specs, 48d85585897aa6ed448ca689b094e60377a25cb7

This addresses an issue where some specs split endpoints between `path`
and `x-ms-path`.  This exposes a significant number of operations across
the generated crates that were not previously included.

NOTE: this was generated using version of the REST specs, 48d85585897aa6ed448ca689b094e60377a25cb7
@bmc-msft bmc-msft requested a review from cataggar April 7, 2022 17:10
@bmc-msft
Copy link
Contributor Author

bmc-msft commented Apr 7, 2022

Note, this PR (or something that accomplishes the same goal) is required to use the generate crates as a backend to the newly added azure_device_update crate.

@bmc-msft
Copy link
Contributor Author

bmc-msft commented Apr 7, 2022

The failures identified in the build are not part of this PR and will be addressed in #719

@@ -10,7 +10,7 @@ The default tag is `package-2022-02`.

The following [tags](https://github.com/Azure/azure-sdk-for-rust/blob/main/services/tags.md) are available:

- `package-2022-02` has 1 operations from 1 API versions: `2022-02-01`. Use crate feature `package-2022-02` to enable. The operations will be in the `package_2022_02` module.
- `package-2022-02` has 70 operations from 1 API versions: `2022-02-01`. Use crate feature `package-2022-02` to enable. The operations will be in the `package_2022_02` module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay 🚀

result.insert(k.clone(), v.clone());
}
}
result
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bmc-msft bmc-msft merged commit 89e9f71 into Azure:main Apr 20, 2022
@bmc-msft bmc-msft deleted the include-paths-and-x_ms_paths branch April 20, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants