Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-TestResources.ps1 doesn't run post-deployment script when using a bicep file #1864

Closed
tjprescott opened this issue Jul 30, 2021 · 0 comments · Fixed by #1876
Closed

New-TestResources.ps1 doesn't run post-deployment script when using a bicep file #1864

tjprescott opened this issue Jul 30, 2021 · 0 comments · Fixed by #1876
Assignees
@ckairen
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@tjprescott
Copy link
Member

tjprescott commented Jul 30, 2021 •
edited
Loading

The change was recently introduced to allow New-TestResources.ps1 to deploy a bicep file directly. After updating our pipeline to use that (removing the ARM template JSON), we found that it no longer called into the test-resources-post.ps1 script following the template deployment.

For now we restored the JSON version of the template and the post-deployment script runs. It seems now it will run deployments for both the JSON file AND the bicep file, which isn't a big deal since once this issue is fixed we'll remove the JSON file again.

  • Runs the JSON template deployment followed by the post-deployoment script
  • Then runs the bicep file deployment but does not run the post-deployment script
@benbp benbp added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2021
@kurtzeborn kurtzeborn assigned ckairen and unassigned benbp Aug 2, 2021
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Aug 2, 2021
@ckairen ckairen linked a pull request Aug 5, 2021 that will close this issue
Fix New-TestResources.ps1 to run pre/post deployment script #1876
Merged
@ghost ghost closed this as completed in #1876 Aug 13, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckairen ckairen

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix New-TestResources.ps1 to run pre/post deployment script ckairen/azure-sdk-tools
4 participants
@benbp @tjprescott @kurtzeborn @ckairen