Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python APIView] Parameterized decorators do not show in APIView. #3028

Closed
xiangyan99 opened this issue Mar 31, 2022 · 1 comment
Closed

[Python APIView] Parameterized decorators do not show in APIView. #3028

xiangyan99 opened this issue Mar 31, 2022 · 1 comment
Assignees
@tjprescott
Labels
APIView Priority 1 APIView bug This issue requires a change to an existing behavior in the product in order to be resolved. Python

Comments

@xiangyan99
Copy link
Member

https://apiview.dev/Assemblies/Review/ee993c29a21746d5b3d98d496b538f93/5d0c16d86dc94dd5a85a8d8fe320014d?diffRevisionId=ab94b712f31a4736a71f6590bb236903&doc=False&diffOnly=False#azure.identity.aio.VisualStudioCodeCredential

We show @log_get_token_async for aio.VisualStudioCodeCredential.get_token(). But it does not show for sync one.
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 31, 2022
@tjprescott
Copy link
Member

I think the issue is not sync/async but the fact that the sync decorator takes arguments and the async one does not.

@tjprescott tjprescott added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Apr 1, 2022
@tjprescott tjprescott changed the title decorator shows in async functions but not sync ones. [Python APIView] Parameterized decorators do not show in APIView. Apr 1, 2022
@tjprescott tjprescott mentioned this issue Apr 1, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjprescott tjprescott

Labels
APIView Priority 1 APIView bug This issue requires a change to an existing behavior in the product in order to be resolved. Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjprescott @xiangyan99