Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: Management Plane Namespace Review Edge Market Place #6586

Closed
aneesh-ponneth opened this issue Aug 31, 2023 · 4 comments
Closed
Assignees
Labels
architecture board-review Request for an Architectural Board Review mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs

Comments

@aneesh-ponneth
Copy link
Member

aneesh-ponneth commented Aug 31, 2023

Thank you for submitting this review request. Thorough review of your management library namespaces ensures that your library names are consistent with the guidelines and the consumers of your management library have a consistently good experience when using Azure.

To ensure consistency, all language library names will generally be reviewed together.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

About the Service (required)

Namespace Proposals (required per language)

In the examples below please replace every occurrence of [ResourceProviderName] with your the service resource provider name. Be sure to keep the casing shown with [ResourceProviderName] when replacing it with the service resource provider name.

  • .NET: Azure.ResourceManager.EdgeMarketplace
  • Java: azure-resourcemanager-edgemarketplace (com.azure.resourcemanager.edgemarketplace)
  • Go/Golang: sdk/resourcemanager/edgemarketplace/armedgemarketplace
  • JavaScript: @azure/arm-edgemarketplace
  • Python: azure-mgmt-edgemarketplace

Thank you!

@aneesh-ponneth aneesh-ponneth added architecture board-review Request for an Architectural Board Review mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs labels Aug 31, 2023
@ronniegeraghty ronniegeraghty changed the title Board Review: Management Plane Namespace Review <client library name> Board Review: Management Plane Namespace Review Edge Market Place Aug 31, 2023
@ArthurMa1978
Copy link
Member

Please remove the Microsoft prefix, the namespace should be:

  • .NET: Azure.ResourceManager.EdgeMarketPlace
  • Java: azure-resourcemanager-edgemarketplace (com.azure.resourcemanager.edgemarketplace)
  • Go/Golang: sdk/resourcemanager/edgemarketplace/armedgemarketplace
  • JavaScript: @azure/arm-edgemarketplace
  • Python: azure-mgmt-edgemarketplace

@ronniegeraghty
Copy link
Member

@aneesh-ponneth, I've updated the proposed namespaces in the description to reflect @ArthurMa1978's comments.
Please give this comment a 👍if they look good to you. Then I'll start the next phase of the review process.

@ronniegeraghty
Copy link
Member

Starting phase 2 of the review. The proposed namespaces will be brought in front of our SDK architects, and they will have 1 week to make any comments or objections to the names. If there are no objections by EoB on 9/26, the namespaces will be considered approved.

@ronniegeraghty
Copy link
Member

The second phase of our review process is over. Only one objection was made for the .NET namespace. The architects pointed out that Marketplace is one word and the "P" in place should not be capitalized. The proposed namespace in the main description of this issue has been changed to reflect this.

The namespaces as they appear in the main description of this issue are approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review mgmt-namespace-review requests for namespace reviews of mgmt plane SDKs
Projects
None yet
Development

No branches or pull requests

4 participants