Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2019-12-python.md #833

Merged
merged 3 commits into from Dec 10, 2019
Merged

Update 2019-12-python.md #833

merged 3 commits into from Dec 10, 2019

Conversation

chlowell
Copy link
Contributor

@chlowell chlowell commented Dec 4, 2019

No description provided.

- `InteractiveBrowserCredential` raises when unable to open a web browser
- The credentials composing `DefaultAzureCredential` are configurable by keyword
arguments
- `SharedTokenCacheCredential` accepts an optional `tenant_id` keyword argument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these really rise to the level of a key feature or improvement? Are these critical? I agree they should be in the CHANGELOG, but I don't see them rising to the level of "critical"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable. Then the note is just e.g. "released version 1.1.0"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like "Released version 1.1.0 of the azure-identity library, which fixes customer reported and usability issues"

@chlowell
Copy link
Contributor Author

/azp run azure-sdk - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chlowell chlowell merged commit a4a2c0f into master Dec 10, 2019
@chlowell chlowell deleted the chlowell-patch-1 branch December 10, 2019 19:58
bterlson pushed a commit to bterlson/azure-sdk that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants