New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Guidelines for tags to use #855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
weshaggard,
mikeharder,
bterlson and
xirzec
December 6, 2019 22:22
bterlson
approved these changes
Dec 6, 2019
xirzec
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits
docs/policies/releases.md
Outdated
|
||
Below are the guidelines for versions and tags to use: | ||
- GA releases will follow [SemVer](https://semver.org/) and the published package should have the tag `latest`. | ||
- If a hot fix is being shipped for a version older than the current GA version, then ensure that the hot fix gets no tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: other places in the docs say hotfix
as one word
Co-Authored-By: Jeff Fisher <xirzec@xirzec.com>
Co-Authored-By: Jeff Fisher <xirzec@xirzec.com>
Co-Authored-By: Jeff Fisher <xirzec@xirzec.com>
weshaggard
approved these changes
Dec 6, 2019
bterlson
pushed a commit
to bterlson/azure-sdk
that referenced
this pull request
Apr 16, 2020
* JS: Guidelines for tags to use * JS: Guidelines for tags to use * tags and hotfixes * Update text on preview packages Co-Authored-By: Jeff Fisher <xirzec@xirzec.com> * Update docs/policies/releases.md Co-Authored-By: Jeff Fisher <xirzec@xirzec.com> * hot fix -> hotfix Co-Authored-By: Jeff Fisher <xirzec@xirzec.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had some discussion around which tags (latest, next, dev) should be used in which scenarios. This PR attempts to capture the notes from that discussion in the guidelines.