This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Use link caching for $management operations (renew locks) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2021 16:30
…ing dispositions or lock renewal (or other management related operations). NOTE: go.mod here is referencing some pre-released commits since this depends on changes in two projects (go-amqp and azure-amqp-common-go). Also, added in a simple stress test. It's a bit manual at the moment, but it initiates 1000 concurrent renew lock calls at once, so it's a decent test of our response routing.
jhendrixMSFT
reviewed
Sep 1, 2021
jhendrixMSFT
reviewed
Sep 1, 2021
jhendrixMSFT
reviewed
Sep 1, 2021
jhendrixMSFT
reviewed
Sep 1, 2021
jhendrixMSFT
reviewed
Sep 1, 2021
|
/azp run Azure.azure-service-bus-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jhendrixMSFT
approved these changes
Sep 2, 2021
|
/azp run Azure.azure-service-bus-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run Azure.azure-service-bus-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
added 2 commits
September 2, 2021 12:38
|
/azp run Azure.azure-service-bus-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run Azure.azure-service-bus-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
(last live test failure was due to throttling of the resource manager calls, so unrelated to the changes we've just made) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@serbrech found a bug where we appear to be having issues when creating a large # of links (in his testing it's somewhere around 200-500).
Our RPCClient (which is what they were using) created a link for each call made, which added up quickly when you were doing parallel lock renewals.
This change makes it so we cache (when possible) a link per entity/address and re-use it for any other other calls that occur. This change goes hand in hand with the change made in Azure/azure-amqp-common-go/pull/53