Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NetworkPolicy to the v2 chart #3160

Closed
tongpu opened this issue Jul 21, 2023 · 1 comment · Fixed by #3164
Closed

Add support for NetworkPolicy to the v2 chart #3160

tongpu opened this issue Jul 21, 2023 · 1 comment · Fixed by #3164
Milestone

Comments

@tongpu
Copy link
Contributor

tongpu commented Jul 21, 2023

Describe the current behavior
When deploying the Azure Service Operator on a cluster with default deny NetworkPolicies for every namespace then the Kubernetes API service is unable to communicate with the operator pod.

Describe the improvement
Add support for deploying NetworkPolicies, which allow Ingress traffic to the pod and Egress from the pod.

Additional context
I have the required NetworkPolicies ready, but I'm unsure how the release process of the Helm chart works right now and would need some guidance on how to contribute this change.

@matthchr
Copy link
Member

I looked and see that a number of other charts do have NetworkPolicies included (w/ a value to turn them off if desired), so it makes sense we should probably do that too.

If you're willing, you can send a PR to add the policies here.

They should have a guard like {{- if .Values.policies.create}}, which I believe it's safe to default to true in the values.yaml.

Much of the chart is generated based on our code-generator (including the CRDs themselves), but since these are static you shouldn't have to worry about that part at all.

The actual release process won't include them until the next generated chart (likely 2.3.0).

@matthchr matthchr added this to the v2.3.0 milestone Jul 24, 2023
tongpu added a commit to tongpu/azure-service-operator that referenced this issue Jul 25, 2023
tongpu added a commit to tongpu/azure-service-operator that referenced this issue Jul 25, 2023
tongpu added a commit to tongpu/azure-service-operator that referenced this issue Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants