Add support for allocation of public ips with ip-tags #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcPow
requested review from
davefellows,
frodopwns,
jananivMS,
matthchr,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
MarcPow
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
babbageclunk
approved these changes
Jul 29, 2020
matthchr
reviewed
Jul 30, 2020
| @@ -23,6 +24,8 @@ type AzurePublicIPAddressSpec struct { | |||
| IdleTimeoutInMinutes int `json:"idleTimeoutInMinutes"` | |||
| PublicIPAddressVersion string `json:"publicIPAddressVersion"` | |||
| SkuName string `json:"skuName"` | |||
| // +optional | |||
| IPTags map[string]string `json:"ipTags,omitempty"` | |||
There was a problem hiding this comment.
@frodopwns - should we regenerate the helm pkg stuff now or do we just do it before we ship?
This was referenced Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1245
What this PR does / why we need it:
This PR allows public ip addresses to be allocated using ip-tags
Special notes for your reviewer:
I've chosen to add this as an option to v1alpha1, as opposed to forking a new version into v1beta, given the maturity of the operator and considering that this is purely additive.
How does this PR make you feel:
Happy!
If applicable: