Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Type Catalog #2630

Merged
merged 6 commits into from Dec 2, 2022
Merged

Improve Type Catalog #2630

merged 6 commits into from Dec 2, 2022

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Adds the owner of each resource, allowing cross checking in the Swagger branch.

Fixes the formatting of Kubernetes Validation rules so they're easier to read.

How does this PR make you feel:
gif

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

│ │ │ ├── Rule 0: {MaxLength %!s(int64=24)}
│ │ │ ├── Rule 1: {MinLength %!s(int64=3)}
│ │ │ └── Rule 2: {Pattern "^[a-zA-Z0-9]+$"}
│ │ │ ├── Rule 0: MaxLength: 24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads much nicer.

@@ -2,14 +2,15 @@ github.com/Azure/azure-service-operator/v2/api/batch/v1alpha1api20210101storage
├── APIVersion: Enum (1 value)
│ └── "2021-01-01"
└── BatchAccount: Resource
├── Owner: github.com/Azure/azure-service-operator/v2/api/resources/v1betav20191001.ResourceGroup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is important.

@theunrepentantgeek theunrepentantgeek merged commit c3328d2 into main Dec 2, 2022
Azure Service Operator Roadmap automation moved this from In Progress to Recently Completed Dec 2, 2022
@theunrepentantgeek theunrepentantgeek deleted the improve/type-catalog-report branch December 2, 2022 21:44
@theunrepentantgeek theunrepentantgeek moved this from Recently Completed to Ready for Release in Azure Service Operator Roadmap Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants