New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Type Catalog #2630
Improve Type Catalog #2630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
│ │ │ ├── Rule 0: {MaxLength %!s(int64=24)} | ||
│ │ │ ├── Rule 1: {MinLength %!s(int64=3)} | ||
│ │ │ └── Rule 2: {Pattern "^[a-zA-Z0-9]+$"} | ||
│ │ │ ├── Rule 0: MaxLength: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads much nicer.
@@ -2,14 +2,15 @@ github.com/Azure/azure-service-operator/v2/api/batch/v1alpha1api20210101storage | |||
├── APIVersion: Enum (1 value) | |||
│ └── "2021-01-01" | |||
└── BatchAccount: Resource | |||
├── Owner: github.com/Azure/azure-service-operator/v2/api/resources/v1betav20191001.ResourceGroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is important.
What this PR does / why we need it:
Adds the owner of each resource, allowing cross checking in the Swagger branch.
Fixes the formatting of Kubernetes Validation rules so they're easier to read.
How does this PR make you feel: