Update Spec for switching to GET/PUT #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
added this to In Progress
in Azure Service Operator Roadmap
via automation
super-harsh
approved these changes
Jan 9, 2023
matthchr
approved these changes
Jan 9, 2023
|
|
||
| Potential mitigation: Where the items in an array have a known identifier (easy for nested resources), use that identifier to match them up. Where the items in an array do not have a known identifier, compare them by index. We may find need for | ||
| Potential mitigation: In the common case where the items in an array have a known identifier, use that identifier to match them up. Where the items in an array do not have a known identifier, compare them by index. |
There was a problem hiding this comment.
Suggested change
| Potential mitigation: In the common case where the items in an array have a known identifier, use that identifier to match them up. Where the items in an array do not have a known identifier, compare them by index. | |
| Potential mitigation: In the common case where the items in an array have a known identifier (for example: When the items represent sub-resources with an `id` field), use that identifier to match them up. Where the items in an array do not have a known identifier, compare them by index. |
There was a problem hiding this comment.
Or possibly a way to phrase it without parens, but which includes that example, which I do think was a good one you had originally highlighted.
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Azure Service Operator Roadmap
automation
moved this from In Progress
to Recently Completed
Jan 10, 2023
matthchr
moved this from Recently Completed
to Ready for Release
in Azure Service Operator Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the spec from #2600 based on subsequent feedback.
Special notes for your reviewer:
Thanks @matthchr
How does this PR make you feel:
If applicable: