-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code generate ResourceGroup #2748
Conversation
Note that I had to edit the recordings but only because the generated code has the same properties in a slightly different order which impacts JSON serialization order. In practice this isn't an issue. I specifically tested old RG to new RG in kind manually by installing the old shape, then installing the new CRDs and operator and using the new shape -- exisitng RGs get reconciled just fine. This is as expected because the JSON shape in etcd hasn't changed even though the storage type has. |
613ceef
to
648a2c6
Compare
648a2c6
to
9e8e200
Compare
9e8e200
to
adf85cf
Compare
/ok-to-test sha=9a72b1f |
Codecov Report
@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 56.01% 56.01% -0.01%
==========================================
Files 973 978 +5
Lines 349026 348295 -731
==========================================
- Hits 195520 195091 -429
+ Misses 122687 122373 -314
- Partials 30819 30831 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/ok-to-test sha=9a72b1f |
Removes the handcrafted ResourceGroup in favor of a code generated one. The two are the same in structure except for
Status.ProvisioningState
, which is nowStatus.Properties.ProvisioningState
(matching ARM).Special notes for your reviewer:
This change is breaking for:
provisioningState
If applicable: