Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump initialDelaySeconds for readiness and liveness probe #2844

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

super-harsh
Copy link
Collaborator

@super-harsh super-harsh commented Apr 5, 2023

What this PR does / why we need it:

The operator pod was running into timeouts on my arm64 mac machine due to readiness probe timeout. This PR bumps the initialDelaySeconds for readiness and liveness probes so that operator gets more time to load and apply CRDs.

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Merging #2844 (b0437f6) into main (c969db9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2844   +/-   ##
=======================================
  Coverage   54.48%   54.49%           
=======================================
  Files        1228     1228           
  Lines      538873   538873           
=======================================
+ Hits       293616   293632   +16     
+ Misses     197266   197243   -23     
- Partials    47991    47998    +7     

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@super-harsh super-harsh merged commit 581e424 into main Apr 6, 2023
8 checks passed
@super-harsh super-harsh deleted the fix/bump-initialDelaySeconds branch April 6, 2023 00:39
emilychu9318 pushed a commit to emilychu9318/azure-service-operator that referenced this pull request Apr 11, 2023
Co-authored-by: Harshdeep Singh <harshdsingh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants