Export AppInsights/Component ConnectionString and InstrumentationKey #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
theunrepentantgeek
approved these changes
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #2899 +/- ##
========================================
Coverage 54.40% 54.40%
========================================
Files 1248 1248
Lines 546976 547288 +312
========================================
+ Hits 297577 297773 +196
- Misses 200647 200723 +76
- Partials 48752 48792 +40
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matthchr
requested changes
Apr 18, 2023
| @@ -22,6 +22,10 @@ github.com/Azure/azure-service-operator/v2/api/insights/v1api20200202 | |||
| │ │ │ └── "LogAnalytics" | |||
| │ │ ├── Kind: *string | |||
| │ │ ├── Location: *string | |||
| │ │ ├── OperatorSpec: *Object (1 property) | |||
| │ │ │ └── ConfigMaps: *Object (2 properties) | |||
| │ │ │ ├── ConnectionString: *genruntime.ConfigMapDestination | |||
There was a problem hiding this comment.
Aren't these secrets, not ConfigMaps?
Shouldn't they be going to secrets?
Or do they not actually contain any secret values?
There was a problem hiding this comment.
I thought the same as well and investigated a bit. Azure docs state its not a secret here
matthchr
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2820
What this PR does / why we need it:
This PR supports exporting ConnectionString and InstrumentationKey for AppInsights/Component.
If applicable: