Add support for subscriptionID on AzureSQL types #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
matthchr
force-pushed
the
feature/asov1-azuresql-subscriptionid
branch
from
1f632a1
to
f162fb6
Compare
theunrepentantgeek
approved these changes
May 1, 2023
| @@ -62,8 +68,14 @@ func (m *AzureSqlFailoverGroupManager) GetDB(ctx context.Context, resourceGroupN | |||
|
|
|||
| // TODO: Delete this? | |||
There was a problem hiding this comment.
Does this need to be actioned or deleted in this PR?
| @@ -48,8 +48,8 @@ func NewAzureSqlUserManager(creds config.Credentials, secretClient secrets.Secre | |||
| } | |||
|
|
|||
| // GetDB retrieves a database | |||
| func (m *AzureSqlUserManager) GetDB(ctx context.Context, resourceGroupName string, serverName string, databaseName string) (azuresql.Database, error) { | |||
| dbClient, err := azuresqlshared.GetGoDbClient(m.Creds) | |||
| func (m *AzureSqlUserManager) GetDB(ctx context.Context, subscriptionID string, resourceGroupName string, serverName string, databaseName string) (azuresql.Database, error) { | |||
There was a problem hiding this comment.
Maybe format these parameters one per line too?
|
/ok-to-test sha=c425ca6 |
Codecov Report
@@ Coverage Diff @@
## main #2910 +/- ##
=======================================
Coverage 54.36% 54.36%
=======================================
Files 1271 1271
Lines 553508 553508
=======================================
+ Hits 300889 300906 +17
+ Misses 203406 203394 -12
+ Partials 49213 49208 -5 |
|
/ok-to-test sha=d093692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applicable: