Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft.Network/bastionHosts #2913

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

matthchr
Copy link
Member

Fixes #2892

What this PR does / why we need it:

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a minor comment for sample naming

@codecov-commenter
Copy link

Codecov Report

Merging #2913 (9ab164a) into main (cb6d078) will decrease coverage by 0.01%.
The diff coverage is 54.59%.

@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   54.41%   54.40%   -0.01%     
==========================================
  Files        1248     1252       +4     
  Lines      547288   548290    +1002     
==========================================
+ Hits       297818   298315     +497     
- Misses     200682   201112     +430     
- Partials    48788    48863      +75     
Impacted Files Coverage Δ
...etwork/v1api20220701/private_endpoint_types_gen.go 52.13% <ø> (ø)
...rk/v1api20220701/private_link_service_types_gen.go 59.39% <ø> (ø)
...v1api20220701storage/private_endpoint_types_gen.go 55.17% <ø> (ø)
...k/v1api20220701/bastion_host_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...pi/network/v1api20220701/bastion_host_types_gen.go 54.30% <54.30%> (ø)
...ork/v1api20220701storage/bastion_host_types_gen.go 55.17% <55.17%> (ø)
...customizations/bastion_host_extension_types_gen.go 100.00% <100.00%> (ø)
...2/internal/controllers/controller_resources_gen.go 87.10% <100.00%> (+0.03%) ⬆️

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthchr
Copy link
Member Author

/ok-to-test sha=0a2efdb

@matthchr matthchr enabled auto-merge (squash) April 20, 2023 16:58
@matthchr matthchr merged commit 4c7fd27 into Azure:main Apr 20, 2023
9 checks passed
@matthchr matthchr deleted the feature/bastion branch April 20, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Add support for Azure Bastions
3 participants