Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving imported resources to separate YAML files #2963

Merged
merged 7 commits into from
May 13, 2023

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Writing all imported resources to a single YAML file doesn't work for some use cases; writing to separate files has been requested by some users so they have better visibility.

Closes #2870

How does this PR make you feel:
gif

@codecov-commenter
Copy link

Codecov Report

Merging #2963 (a0c943c) into main (400acb1) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a0c943c differs from pull request most recent head b59329f. Consider uploading reports for the commit b59329f to get more accurate results

@@           Coverage Diff           @@
##             main    #2963   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files        1322     1322           
  Lines      557736   557755   +19     
=======================================
+ Hits       302311   302334   +23     
+ Misses     206025   206022    -3     
+ Partials    49400    49399    -1     
Impacted Files Coverage Δ
...soctl/internal/importing/resource_import_result.go 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments

v2/cmd/asoctl/cmd/import_azure_resource.go Outdated Show resolved Hide resolved
@theunrepentantgeek theunrepentantgeek enabled auto-merge (squash) May 13, 2023 00:34
@theunrepentantgeek theunrepentantgeek merged commit ea53767 into main May 13, 2023
8 checks passed
@theunrepentantgeek theunrepentantgeek deleted the feature/save-to-multiple-files branch May 13, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add option to export each resource to a separate file
3 participants