Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DnsForwardingRuleSet, DnsForwardingRuleSetForwardingRule, DnsResolver, DnsResolversInboundEndpoint and DnsResolversOutboundEndpoint #3046

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

super-harsh
Copy link
Collaborator

Closes #2800

What this PR does / why we need it:

Adds support for DnsForwardingRuleSet, DnsForwardingRuleSetForwardingRule, DnsResolver, DnsResolversInboundEndpoint and DnsResolversOutboundEndpoint resources.

If applicable:

  • this PR contains tests

…rule, dnsresolver, dnsresolversinboundendpoint and dnsresolversoutboundendpoint
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #3046 (3ea8e05) into main (52d94c8) will increase coverage by 0.00%.
The diff coverage is 58.41%.

@@            Coverage Diff            @@
##             main    #3046     +/-   ##
=========================================
  Coverage   54.27%   54.28%             
=========================================
  Files        1379     1399     +20     
  Lines      596286   599179   +2893     
=========================================
+ Hits       323664   325239   +1575     
- Misses     219482   220604   +1122     
- Partials    53140    53336    +196     
Impacted Files Coverage Δ
...20701/dns_forwarding_ruleset_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...ing_rulesets_forwarding_rule_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...k/v1api20220701/dns_resolver_spec_arm_types_gen.go 33.33% <33.33%> (ø)
...s_resolvers_inbound_endpoint_spec_arm_types_gen.go 33.33% <33.33%> (ø)
..._resolvers_outbound_endpoint_spec_arm_types_gen.go 33.33% <33.33%> (ø)
..._forwarding_rule_sets_forwarding_rule_types_gen.go 55.17% <55.17%> (ø)
...0220701storage/dns_forwarding_ruleset_types_gen.go 55.17% <55.17%> (ø)
...ork/v1api20220701storage/dns_resolver_types_gen.go 55.17% <55.17%> (ø)
...torage/dns_resolvers_inbound_endpoint_types_gen.go 55.17% <55.17%> (ø)
...orage/dns_resolvers_outbound_endpoint_types_gen.go 55.17% <55.17%> (ø)
... and 11 more

... and 33 files with indirect coverage changes

│ │ ├── Metadata: map[string]string
│ │ ├── Owner: *genruntime.KnownResourceReference
│ │ └── TargetDnsServers: Object (2 properties)[]
│ │ ├── IpAddress: *string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be able to source from configMap?

Also happy to defer until user requests if we don't know of an interesting use-case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, might as well chuck in an optional configmap ref import.

v2/internal/controllers/crd_networking_dnsresolver_test.go Outdated Show resolved Hide resolved
v2/internal/controllers/crd_networking_dnsresolver_test.go Outdated Show resolved Hide resolved

tc.CreateResourcesAndWait(vnet, subnet, resolver, outboundEP)

ruleSet := &v1api20220701.DnsForwardingRuleset{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Maybe alias this to just network? It's easier to read than v1api20220701

@super-harsh super-harsh merged commit c099a42 into main Jun 13, 2023
9 checks passed
@super-harsh super-harsh deleted the feature/dnsresolver branch June 13, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add support for Azure DNS Private Resolver and ForwardingRuleSets
3 participants