-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DnsForwardingRuleSet, DnsForwardingRuleSetForwardingRule, DnsResolver, DnsResolversInboundEndpoint and DnsResolversOutboundEndpoint #3046
Conversation
…rule, dnsresolver, dnsresolversinboundendpoint and dnsresolversoutboundendpoint
Codecov Report
@@ Coverage Diff @@
## main #3046 +/- ##
=========================================
Coverage 54.27% 54.28%
=========================================
Files 1379 1399 +20
Lines 596286 599179 +2893
=========================================
+ Hits 323664 325239 +1575
- Misses 219482 220604 +1122
- Partials 53140 53336 +196
|
│ │ ├── Metadata: map[string]string | ||
│ │ ├── Owner: *genruntime.KnownResourceReference | ||
│ │ └── TargetDnsServers: Object (2 properties)[] | ||
│ │ ├── IpAddress: *string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be able to source from configMap?
Also happy to defer until user requests if we don't know of an interesting use-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, might as well chuck in an optional configmap ref import.
|
||
tc.CreateResourcesAndWait(vnet, subnet, resolver, outboundEP) | ||
|
||
ruleSet := &v1api20220701.DnsForwardingRuleset{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: Maybe alias this to just network
? It's easier to read than v1api20220701
Closes #2800
What this PR does / why we need it:
Adds support for DnsForwardingRuleSet, DnsForwardingRuleSetForwardingRule, DnsResolver, DnsResolversInboundEndpoint and DnsResolversOutboundEndpoint resources.
If applicable: