Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asoctl when importing resources with fixed names #3099

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

If a resource being imported has a fixed name, it doesn't have an AzureName property and asoctl was encountering a panic.

Fixes #3098

How does this PR make you feel:
gif

@codecov-commenter
Copy link

Codecov Report

Merging #3099 (aa8b602) into main (49990e3) will increase coverage by 0.06%.
The diff coverage is 29.31%.

@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
+ Coverage   54.16%   54.23%   +0.06%     
==========================================
  Files        1400     1400              
  Lines      601166   601178      +12     
==========================================
+ Hits       325622   326030     +408     
+ Misses     222144   221742     -402     
- Partials    53400    53406       +6     
Impacted Files Coverage Δ
...octl/internal/importing/importable_arm_resource.go 2.66% <0.00%> (-0.06%) ⬇️
...ctl/internal/importing/resource_importer_report.go 0.00% <0.00%> (ø)
...ator/internal/config/object_model_configuration.go 71.36% <0.00%> (-0.07%) ⬇️
...ator/internal/config/supported_resources_report.go 16.66% <ø> (ø)
...ernal/codegen/pipeline/report_resource_versions.go 51.65% <28.57%> (-0.72%) ⬇️
...peline/apply_defaulter_and_validator_interfaces.go 25.00% <69.23%> (+2.07%) ⬆️
...nerator/internal/interfaces/defaulter_interface.go 77.77% <75.00%> (ø)

... and 33 files with indirect coverage changes

@theunrepentantgeek theunrepentantgeek enabled auto-merge (squash) June 22, 2023 20:41
@theunrepentantgeek theunrepentantgeek enabled auto-merge (squash) June 22, 2023 20:41
@theunrepentantgeek theunrepentantgeek merged commit d8f6813 into main Jun 22, 2023
8 checks passed
@theunrepentantgeek theunrepentantgeek deleted the fix/asoctl-panic branch June 22, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bug: asoctl panic during import
3 participants