added corner cases for comments.go in astbuilder package #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
khareyash05
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
requested changes
Jul 10, 2023
Comment on lines
52
to
54
| if c.comment == "" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
All this does is to suppress the new test case - it's never run at all, so it adds nothing to the coverage.
There was a problem hiding this comment.
Will update the same
Comment on lines
81
to
83
| if c.width == 0 { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Ditto here; all you're doing is skipping the test if the passed width is zero.
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
| @@ -70,6 +71,8 @@ func TestWordWrap(t *testing.T) { | |||
| {"this is a simple line of text", 16, []string{"this is a simple ", "line of text"}}, | |||
| {"this is a simple line of text", 20, []string{"this is a simple ", "line of text"}}, | |||
| {"this is a simple line of text", 21, []string{"this is a simple line ", "of text"}}, | |||
| {"", 0, []string{}}, | |||
| {"this is a sample text", 0, []string{}}, | |||
There was a problem hiding this comment.
We should never throw away content like this - if someone inadvertently passes a width of 0 we want to return the content anyway. For consistency with existing behaviour when width is 1, this should be:
Suggested change
| {"this is a sample text", 0, []string{}}, | |
| {"this is a sample text", 0, []string{"this ", "is ", "a ", "sample ", "text"}}, |
theunrepentantgeek
requested changes
Jul 12, 2023
Signed-off-by: Yash Khare <yash2010118@akgec.ac.in>
|
/ok-to-test sha=7ee6c95 |
Codecov Report
@@ Coverage Diff @@
## main #3134 +/- ##
==========================================
- Coverage 54.17% 54.15% -0.03%
==========================================
Files 1418 1419 +1
Lines 608163 608072 -91
==========================================
- Hits 329486 329311 -175
- Misses 224662 224764 +102
+ Partials 54015 53997 -18
|
|
/ok-to-test sha=e3be922 |
theunrepentantgeek
approved these changes
Jul 17, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @khareyash05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Increase test coverage of
astbuillder/comments.goto add corner cases of empty comments and text width =0If applicable: