Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify SQL "PasswordNotComplex" as fatal #3185

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

matthchr
Copy link
Member

The "PasswordNotComplex" error should be treated as fatal

If applicable:

  • this PR contains documentation
  • this PR contains tests

The "PasswordNotComplex" error should be treated as fatal
@matthchr matthchr force-pushed the feature/azure-sql-password-complex-fix branch from 39a8079 to 1505091 Compare August 11, 2023 18:04
@matthchr
Copy link
Member Author

/ok-to-test sha=89c8525

@matthchr matthchr enabled auto-merge (squash) August 14, 2023 20:44
@codecov-commenter
Copy link

Codecov Report

Merging #3185 (89c8525) into main (f2c8825) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
+ Coverage   54.36%   54.38%   +0.02%     
==========================================
  Files        1421     1422       +1     
  Lines      601271   601278       +7     
==========================================
+ Hits       326868   327008     +140     
+ Misses     220947   220801     -146     
- Partials    53456    53469      +13     
Files Changed Coverage Δ
...2/api/sql/customizations/server_extension_types.go 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

@matthchr matthchr disabled auto-merge August 14, 2023 21:15
@matthchr matthchr merged commit 5322b4f into Azure:main Aug 14, 2023
8 checks passed
@matthchr matthchr deleted the feature/azure-sql-password-complex-fix branch August 14, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants