Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new versions of cache RP #3206

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

matthchr
Copy link
Member

If applicable:

  • this PR contains documentation
  • this PR contains tests

@matthchr
Copy link
Member Author

/ok-to-test sha=96cb206

@codecov-commenter
Copy link

Codecov Report

Merging #3206 (96cb206) into main (239eea7) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 57.56%.

@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
+ Coverage   54.39%   54.48%   +0.09%     
==========================================
  Files        1424     1442      +18     
  Lines      601351   614666   +13315     
==========================================
+ Hits       327097   334904    +7807     
- Misses     220754   224925    +4171     
- Partials    53500    54837    +1337     
Files Changed Coverage Δ
v2/api/cache/customizations/redis_extensions.go 75.43% <ø> (ø)
v2/api/cache/v1api20230401/redis_types_gen.go 55.02% <ø> (ø)
...pi20230401storage/redis_firewall_rule_types_gen.go 55.17% <ø> (ø)
...pi20230401storage/redis_linked_server_types_gen.go 55.17% <ø> (ø)
...i20230401storage/redis_patch_schedule_types_gen.go 55.17% <ø> (ø)
.../api/cache/v1api20230401storage/redis_types_gen.go 59.75% <ø> (ø)
...01/redis_enterprise_database_spec_arm_types_gen.go 33.33% <ø> (ø)
...api20230701/redis_enterprise_database_types_gen.go 56.03% <ø> (ø)
...api20230701/redis_enterprise_spec_arm_types_gen.go 33.33% <ø> (ø)
.../cache/v1api20230701/redis_enterprise_types_gen.go 60.17% <ø> (ø)
... and 38 more

... and 134 files with indirect coverage changes

@@ -0,0 +1,19 @@
apiVersion: cache.azure.com/v1api20230401
Copy link
Collaborator

@super-harsh super-harsh Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest separating these samples out in their own folders like v1api20230401 and v1api20201201 for consistency with other groups

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every group does this actually, and because there's a bunch of API versions coexisting (because of redis + redisenterprise) it felt better to put it all into 1 folder like we do for compute so that people don't have to guess which API versions support which resources. Basically I think people are resource-centric and making them choose API versions first doesn't help in sample discovery. It's fine when every resource is in every API version (pick any one and you're right), but in this case not every resource is in every APIversion so it's harder.

Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a couple minors comments.

@matthchr
Copy link
Member Author

/ok-to-test sha=ff9576d

@matthchr matthchr merged commit e33c48b into Azure:main Aug 29, 2023
9 checks passed
@matthchr matthchr deleted the feature/new-redis branch August 29, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants