Update asoctl clean command to clean beta CRDs #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
This command will no longer work on alpha relases because we changed how the CRD listing is done (now uses label, which alpha doesn't have), but as per our metrics alpha has no more usage, and older asoctl versions will still work to clean alpha.
matthchr
force-pushed
the
feature/cleaner-beta
branch
from
04c61a2
to
f617389
Compare
theunrepentantgeek
approved these changes
Oct 13, 2023
|
/ok-to-test sha=f617389 |
super-harsh
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will no longer work on alpha relases because we changed how the CRD listing is done (now uses label, which alpha doesn't have), but as per our metrics alpha has no more usage, and older asoctl versions will still work to clean alpha.
What this PR does / why we need it:
Special notes for your reviewer:
How does this PR make you feel:
If applicable: