Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM: ProductPolicy and ProductApi #3552

Merged
merged 12 commits into from
Jan 3, 2024

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Nov 14, 2023

Relates #3398

This implements ProductPolicy and ProductApi which was not possible to generate until #3530 was complete.

Special notes for your reviewer:
CRD sample tests for this are disabled because it takes too long to build.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@ross-p-smith ross-p-smith changed the title ProductPolicy APIM: ProductPolicy Nov 14, 2023
@matthchr
Copy link
Member

This won't work in the actual controller until I merge this: #3530

@ross-p-smith ross-p-smith changed the title APIM: ProductPolicy APIM: ProductPolicy and ProductApi Nov 23, 2023
@ross-p-smith ross-p-smith marked this pull request as ready for review November 23, 2023 23:18
@theunrepentantgeek
Copy link
Member

We've merged a fix for the broken link that's breaking CI in #3595 - merge main into your branch and that should pass.

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving, because this lacks samples. Looking good though!

v2/azure-arm.yaml Outdated Show resolved Hide resolved
v2/azure-arm.yaml Outdated Show resolved Hide resolved
@super-harsh
Copy link
Collaborator

PR looks good to me! The only thing missing is a test recording for samples. Here's the guide to record samples test.

@codecov-commenter
Copy link

Codecov Report

Attention: 1292 lines in your changes are missing coverage. Please review.

Comparison is base (f6ab7ee) 53.08% compared to head (fff2a94) 53.42%.
Report is 25 commits behind head on main.

Files Patch % Lines
...1/storage/managed_clusters_agent_pool_types_gen.go 70.23% 216 Missing and 140 partials ⚠️
...230202preview/storage/managed_cluster_types_gen.go 58.30% 148 Missing and 108 partials ⚠️
...nagement/v1api20220801/product_policy_types_gen.go 49.51% 137 Missing and 18 partials ⚠️
...imanagement/v1api20220801/product_api_types_gen.go 42.04% 124 Missing and 18 partials ⚠️
...1/storage/compat/service_mesh_profile_types_gen.go 50.99% 60 Missing and 39 partials ⚠️
...ge/compat/service_mesh_profile_status_types_gen.go 52.97% 56 Missing and 39 partials ⚠️
...ompat/cluster_upgrade_settings_status_types_gen.go 55.55% 24 Missing and 16 partials ⚠️
...orage/compat/cluster_upgrade_settings_types_gen.go 62.22% 20 Missing and 14 partials ⚠️
...ent/v1api20220801/storage/product_api_types_gen.go 56.66% 24 Missing and 2 partials ⚠️
.../v1api20220801/storage/product_policy_types_gen.go 57.37% 24 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3552      +/-   ##
==========================================
+ Coverage   53.08%   53.42%   +0.34%     
==========================================
  Files        1286     1364      +78     
  Lines      406699   462098   +55399     
==========================================
+ Hits       215894   246881   +30987     
- Misses     159804   178129   +18325     
- Partials    31001    37088    +6087     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@super-harsh
Copy link
Collaborator

/ok-to-test sha=fff2a94

@tomkerkhove
Copy link
Member

@super-harsh It looks like something is blocking auto-merge, what do we need to do?

@super-harsh
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@super-harsh super-harsh added this pull request to the merge queue Jan 3, 2024
Merged via the queue into Azure:main with commit 5bac6d1 Jan 3, 2024
9 checks passed
@ross-p-smith ross-p-smith deleted the ross/productpolicy branch January 4, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants