-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIM: ProductPolicy and ProductApi #3552
Conversation
This won't work in the actual controller until I merge this: #3530 |
We've merged a fix for the broken link that's breaking CI in #3595 - merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving, because this lacks samples. Looking good though!
PR looks good to me! The only thing missing is a test recording for samples. Here's the guide to record samples test. |
/ok-to-test sha=fff2a94 |
@super-harsh It looks like something is blocking auto-merge, what do we need to do? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Relates #3398
This implements ProductPolicy and ProductApi which was not possible to generate until #3530 was complete.
Special notes for your reviewer:
CRD sample tests for this are disabled because it takes too long to build.
How does this PR make you feel:
If applicable: