Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version of PostgreSQL #3593

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Nov 23, 2023

What this PR does / why we need it:

Add support for the 2022-12-01 API version of PostgreSQL.

One of the updates tracked in #3294

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 1475 lines in your changes are missing coverage. Please review.

Comparison is base (7f4298d) 53.29% compared to head (d592bc3) 53.30%.

Files Patch % Lines
...v1api20210601/storage/flexible_server_types_gen.go 56.58% 274 Missing and 174 partials ⚠️
...api20221201/flexible_servers_database_types_gen.go 49.56% 151 Missing and 21 partials ⚠️
...221201/flexible_servers_firewall_rule_types_gen.go 50.43% 149 Missing and 20 partials ⚠️
...221201/flexible_servers_configuration_types_gen.go 58.95% 143 Missing and 22 partials ⚠️
...torage/flexible_servers_configuration_types_gen.go 60.61% 65 Missing and 24 partials ⚠️
...601/storage/flexible_servers_database_types_gen.go 51.63% 65 Missing and 24 partials ⚠️
...torage/flexible_servers_firewall_rule_types_gen.go 51.63% 65 Missing and 24 partials ⚠️
...220120preview/storage/flexible_server_types_gen.go 44.08% 28 Missing and 24 partials ⚠️
...v1api20221201/storage/flexible_server_types_gen.go 49.27% 33 Missing and 2 partials ⚠️
...torage/flexible_servers_configuration_types_gen.go 55.93% 24 Missing and 2 partials ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3593      +/-   ##
==========================================
+ Coverage   53.29%   53.30%   +0.01%     
==========================================
  Files        1327     1339      +12     
  Lines      432910   438146    +5236     
==========================================
+ Hits       230731   233567    +2836     
- Misses     168311   170088    +1777     
- Partials    33868    34491     +623     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do you think its worth making the controller test for older version to use the latest version we support(since not adding controller test)?

@theunrepentantgeek
Copy link
Member Author

LGTM! Do you think its worth making the controller test for older version to use the latest version we support(since not adding controller test)?

Good idea, done.

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit c19c579 Nov 30, 2023
9 checks passed
@theunrepentantgeek theunrepentantgeek deleted the feature/update-dbforpostgresql branch November 30, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants