Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIM: Add v2 SKU #3673

Merged
merged 9 commits into from
Jan 9, 2024
Merged

APIM: Add v2 SKU #3673

merged 9 commits into from
Jan 9, 2024

Conversation

ross-p-smith
Copy link
Contributor

@ross-p-smith ross-p-smith commented Dec 21, 2023

This PR adds v2 SKU of API Service

Relates to #2747

Special notes for your reviewer:

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 1225 lines in your changes are missing coverage. Please review.

Comparison is base (5bac6d1) 53.50% compared to head (e487dde) 53.50%.

Files Patch % Lines
...ment/v1api20230501preview/named_value_types_gen.go 52.44% 223 Missing and 49 partials ⚠️
...nagement/v1api20230501preview/product_types_gen.go 58.76% 146 Missing and 35 partials ⚠️
.../v1api20230501preview/api_version_set_types_gen.go 57.03% 133 Missing and 32 partials ⚠️
.../v1api20230501preview/policy_fragment_types_gen.go 55.84% 121 Missing and 30 partials ⚠️
...anagement/v1api20230501preview/policy_types_gen.go 53.46% 112 Missing and 29 partials ⚠️
...t/v1api20230501preview/product_policy_types_gen.go 53.46% 112 Missing and 29 partials ⚠️
...ment/v1api20230501preview/product_api_types_gen.go 45.74% 105 Missing and 29 partials ⚠️
...i20230501preview/service_api_spec_arm_types_gen.go 33.33% 4 Missing ⚠️
...view/service_api_version_set_spec_arm_types_gen.go 33.33% 4 Missing ⚠️
...30501preview/service_backend_spec_arm_types_gen.go 33.33% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3673      +/-   ##
==========================================
  Coverage   53.50%   53.50%              
==========================================
  Files        1364     1397      +33     
  Lines      461340   477149   +15809     
==========================================
+ Hits       246829   255307    +8478     
- Misses     177522   183286    +5764     
- Partials    36989    38556    +1567     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me.

@matthchr
Copy link
Member

matthchr commented Jan 5, 2024

/ok-to-test sha=b7ae9b8

@matthchr
Copy link
Member

matthchr commented Jan 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr
Copy link
Member

matthchr commented Jan 5, 2024

/ok-to-test sha=b7ae9b8

1 similar comment
@matthchr
Copy link
Member

matthchr commented Jan 5, 2024

/ok-to-test sha=b7ae9b8

@matthchr
Copy link
Member

matthchr commented Jan 5, 2024

/ok-to-test sha=e487dde

@matthchr
Copy link
Member

matthchr commented Jan 8, 2024

Our CI SP expired - once that's fixed we'll merge this.

@tomkerkhove
Copy link
Member

Oh the certainties in life!

@super-harsh super-harsh added this pull request to the merge queue Jan 8, 2024
Merged via the queue into Azure:main with commit e189825 Jan 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants