Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signalr keys #3698

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Signalr keys #3698

merged 9 commits into from
Jan 12, 2024

Conversation

mehighlow
Copy link
Contributor

Closes #3406

What this PR does / why we need it:
This PR adds SignalR API keys export

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had a few small comments.

go.mod Outdated Show resolved Hide resolved
v2/internal/controllers/crd_signalr_test.go Outdated Show resolved Hide resolved
v2/internal/controllers/crd_signalr_test.go Outdated Show resolved Hide resolved
mehighlow and others added 4 commits January 11, 2024 20:49
…ization.go

Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
@matthchr
Copy link
Member

/ok-to-test sha=ffd9180

@matthchr
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr
Copy link
Member

/ok-to-test sha=159b4eb

@matthchr
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (feb9506) 53.54% compared to head (159b4eb) 53.57%.
Report is 4 commits behind head on main.

Files Patch % Lines
...signalrservice/v1api20211001/signal_r_types_gen.go 77.65% 5 Missing and 16 partials ⚠️
...customizations/signal_r_extention_authorization.go 70.45% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3698      +/-   ##
==========================================
+ Coverage   53.54%   53.57%   +0.02%     
==========================================
  Files        1376     1411      +35     
  Lines      467398   483451   +16053     
==========================================
+ Hits       250285   258989    +8704     
- Misses     179480   185246    +5766     
- Partials    37633    39216    +1583     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr matthchr added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Azure:main with commit d4e10a6 Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: expose SignalR credentials
3 participants