Ensure reconciling condition overwrites AzureResourceNotFound #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Azure#3788. AzureResourceNotFound only comes up when ReconcilePolicy is skip. This conditions priority being less than Reconciling allows skip -> reconcile to immediately update the condition to Reconciling rather than continuing to report AzureResourceNotFound until the resource is created.
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=10c6c51 |
theunrepentantgeek
approved these changes
Mar 4, 2024
| ReasonReconciling.Name: -1, | ||
| // AzureResourceNotFound only comes up when ReconcilePolicy is skip. This conditions priority being less than | ||
| // Reconciling allows skip -> reconcile to immediately update the condition to Reconciling rather than continuing to | ||
| // report AzureResourceNotFound until the resource is created. |
There was a problem hiding this comment.
Suggested change
| // report AzureResourceNotFound until the resource is created. | |
| // report AzureResourceNotFound until resource has completed. |
There was a problem hiding this comment.
This phrasing doesn't seem clearer to me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3788.
AzureResourceNotFound only comes up when ReconcilePolicy is skip. This conditions priority being less than Reconciling allows skip -> reconcile to immediately update the condition to Reconciling rather than continuing to report AzureResourceNotFound until the resource is created.
If applicable: