Add support for Insight/Webtest 2022-06-15 #3911
Conversation
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
super-harsh
added
the
new-resouce-version
v2/api/containerservice/v1api20230315preview/fleets_update_run_spec_arm_types_gen.go
Outdated
Show resolved
Hide resolved
| @@ -2,93 +2,108 @@ | |||
| github.com/Azure/azure-service-operator/v2/api/insights/v1api20180501preview/storage | |||
| ├── APIVersion: Enum (1 value) | |||
| │ └── "2018-05-01-preview" | |||
| └── Webtest: Resource | |||
There was a problem hiding this comment.
minor: @theunrepentantgeek, it would be nice if the format for this file didn't change so drastically when additions were made.
Maybe pure whitespace/indentation is enough and we can drop the |? Or maybe we could just render | anyway even if there's nothing below so that when something is added the change doesn't edit all the above lines too?
LMK if you think worth filing an issue over it.
| │ │ ├── Description: *string | ||
| │ │ ├── Enabled: *bool | ||
| │ │ ├── Frequency: *int | ||
| │ │ ├── Kind: *Enum (3 values) |
There was a problem hiding this comment.
The old API had a basic entry here... not sure what we need to do with that (if anything), but it won't roundtrip forward/backwards.
There was a problem hiding this comment.
I think PropertyConversion functions would handle that by adding the extra property in PropertyBag?
Not sure, calling @theunrepentantgeek here as he knows the conversions better.
| namespace: default | ||
| spec: | ||
| tags: | ||
| "hidden-link:/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/aso-sample-rg/providers/microsoft.insights/components/sampleappinsights": Resource |
There was a problem hiding this comment.
minor: Do we know that this is still required for the new webtest type?
There was a problem hiding this comment.
Good point, I'll double check and post an update.
There was a problem hiding this comment.
Double-checked. Its still needed. Getting a 400 Bad request with message below:
"A single 'hidden-link' tag pointing to an existing AI component is required. Found none."
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
What this PR does / why we need it:
Closes #3294
Add support for stable Insight preview resources.
Special notes for your reviewer:
How does this PR make you feel:
If applicable: