Fix bug where we could fail to emit user requested secrets or configmaps #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
added
bug 🪲
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
This was referenced Apr 8, 2024
|
/ok-to-test sha=ca1ba70 |
theunrepentantgeek
approved these changes
Apr 10, 2024
matthchr
force-pushed
the
feature/fix-skip-bug
branch
from
ca1ba70
to
9f35693
Compare
super-harsh
approved these changes
Apr 11, 2024
super-harsh
reviewed
Apr 11, 2024
If the user requests a particular secret or configmap value be written, we should error if we are unable to write it and retry.
matthchr
force-pushed
the
feature/fix-skip-bug
branch
from
9f35693
to
fed84ac
Compare
|
/ok-to-test sha=fed84ac |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user requests a particular secret or configmap value be written, we should error if we are unable to write it and retry.
If applicable: