Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update available version of DocumentDB #3967

Merged
merged 38 commits into from
May 8, 2024
Merged

Update available version of DocumentDB #3967

merged 38 commits into from
May 8, 2024

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Adds the 2023-11-15 version of resources from the documentdb group.

Closes #3768
How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@theunrepentantgeek theunrepentantgeek self-assigned this Apr 23, 2024
@theunrepentantgeek theunrepentantgeek added documentation Improvements or additions to documentation new-resouce-version New version of a resource ASO already supports labels Apr 23, 2024
@theunrepentantgeek theunrepentantgeek added this to the v2.7.0 milestone Apr 23, 2024
@matthchr
Copy link
Member

Intermittent test failure? Looks possibly related to the PR so maybe it's not intermittent?

matthchr
matthchr approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but LGTM overall

v2/api/documentdb/v1api20231115/structure.txt Show resolved Hide resolved
v2/internal/controllers/documentdb_mongodb_crud_v20231115_test.go Outdated Show resolved Hide resolved
v2/internal/controllers/documentdb_mongodb_crud_v20231115_test.go Outdated Show resolved Hide resolved
v2/internal/controllers/documentdb_sql_crud_v20231115_test.go Show resolved Hide resolved
v2/internal/controllers/documentdb_sql_crud_v20231115_test.go Outdated Show resolved Hide resolved
super-harsh
super-harsh approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one on tutorial. It adds a lot of value to guide new contributors.
Just a minor one below.

docs/hugo/content/tutorials/upgrade-resource-version/_index.md Outdated Show resolved Hide resolved
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.7.0, v2.8.0 Apr 24, 2024
@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit b521df8 May 8, 2024
9 checks passed
@theunrepentantgeek theunrepentantgeek deleted the feature/update-documentdb branch May 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthchr matthchr matthchr approved these changes

@super-harsh super-harsh super-harsh approved these changes

@davefellows davefellows Awaiting requested review from davefellows davefellows is a code owner

@babbageclunk babbageclunk Awaiting requested review from babbageclunk babbageclunk is a code owner

Assignees

@theunrepentantgeek theunrepentantgeek

Labels
documentation Improvements or additions to documentation new-resouce-version New version of a resource ASO already supports
Projects
Azure Service Operator Roadmap
Status: Ready for Release
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

Upgrade Microsoft.DocumentDB databaseAccounts to the latest API version 2023-04-15
3 participants
@theunrepentantgeek @matthchr @super-harsh