Obsolete UseAzureSignalR #1605
Merged
Obsolete UseAzureSignalR #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…= 3.1. Replace it with IApplicationBuilder.UseEndpoints()
vicancy
reviewed
May 11, 2022
| @@ -19,6 +19,9 @@ public static class AzureSignalRApplicationBuilderExtensions | |||
| /// <param name="app">The <see cref="IApplicationBuilder"/>.</param> | |||
| /// <param name="configure">A callback to configure the <see cref="ServiceRouteBuilder"/>.</param> | |||
| /// <returns>The same instance of the <see cref="IApplicationBuilder"/> for chaining.</returns> | |||
| #if NETCOREAPP3_1_OR_GREATER || NET5_0_OR_GREATER | |||
There was a problem hiding this comment.
use #if !NETSTANDARD2_0 to be consistent with how we support UseEndpoint in AzureSignalRHostingStartup?
vicancy
approved these changes
May 13, 2022
xingsy97
changed the title
vicancy
reviewed
May 16, 2022
Co-authored-by: Liangying.Wei <lianwei@microsoft.com>
vicancy
approved these changes
May 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Fixes #1602