Add error when chunkSize is greater than the strict memory limit of the CacheLimiter. #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he CacheLimiter.
Scenario:
export AZCOPY_BUFFER_GB=5
# Copy a single 5GB file to an Azure Blob Storage Container with a block size of 4000MB
./acopy [...] --block-size-mb=4000 [...]
Since the chunk size in that case is greater than the strict memory limit (75% of 5GB)
this would end up in a deadlock: CacheLimiter.TryAdd would loop forever, waiting for memory
to be freed (which it never will).
This patch tries to remedy that by making it an error if a chunk is greater than the strict
memory limit of the associated CacheLimiter.
mkrautz
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
gapra-msft
approved these changes
May 24, 2023
adreed-msft
approved these changes
May 24, 2023
siminsavani-msft
approved these changes
May 24, 2023
tasherif-msft
approved these changes
May 24, 2023
nakulkar-msft
approved these changes
May 25, 2023
nakulkar-msft
pushed a commit
that referenced
this pull request
May 31, 2023
…he CacheLimiter. (#2228) Scenario: export AZCOPY_BUFFER_GB=5 # Copy a single 5GB file to an Azure Blob Storage Container with a block size of 4000MB ./acopy [...] --block-size-mb=4000 [...] Since the chunk size in that case is greater than the strict memory limit (75% of 5GB) this would end up in a deadlock: CacheLimiter.TryAdd would loop forever, waiting for memory to be freed (which it never will). This patch tries to remedy that by making it an error if a chunk is greater than the strict memory limit of the associated CacheLimiter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error when chunkSize is greater than the strict memory limit of the CacheLimiter.
Scenario:
Since the chunk size in that case is greater than the strict memory limit (75% of 5GB) this would end up in a deadlock: CacheLimiter.TryAdd would loop forever, waiting for memory to be freed (which it never will).
This patch tries to remedy that by making it an error if a chunk is greater than the strict memory limit of the associated CacheLimiter.