Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error when chunkSize is greater than the strict memory limit of the CacheLimiter. #2228

Merged

Commits on May 24, 2023

  1. Add error when chunkSize is greater than the strict memory limit of t…

    …he CacheLimiter.
    
    Scenario:
    
        export AZCOPY_BUFFER_GB=5
        # Copy a single 5GB file to an Azure Blob Storage Container with a block size of 4000MB
        ./acopy [...] --block-size-mb=4000 [...]
    
    Since the chunk size in that case is greater than the strict memory limit (75% of 5GB)
    this would end up in a deadlock: CacheLimiter.TryAdd would loop forever, waiting for memory
    to be freed (which it never will).
    
    This patch tries to remedy that by making it an error if a chunk is greater than the strict
    memory limit of the associated CacheLimiter.
    mkrautz committed May 24, 2023
    Configuration menu
    Copy the full SHA
    901e8de View commit details
    Browse the repository at this point in the history